Added integration tests for validating JMX_PORT config #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it make sense to just mark the expected-to-fail test as disabled for now? |
nickbp
reviewed
Sep 21, 2016
| "cassandra": { | ||
| "jmx_port": 8199 | ||
| } | ||
| } |
|
@nickbp Let me mark that test as disabled, and add a task to remind that we need to enable this test. |
|
@mesosphere-ci retest this please |
|
@mesosphere-ci retest this please |
|
@mesosphere-ci retest this please |
1 similar comment
|
@mesosphere-ci retest this please |
|
@mohitsoni: The needed change in binary dependency has been made. All tests have passed. Can you get this PR across the line if it is still needed? |
|
retest this please |
nickbp
approved these changes
Jul 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two integration tests for validating:
JMX_PORTbeing set to 7199 (test_jmx_default)JMX_PORT(test_jmx_override)Note: The test automation will report
test_jmx_defaultasPASSINGandtest_jmx_overrideasFAILED.test_jmx_overridewill fail for this PR because we have not updated thehttps://downloads.mesosphere.com/cassandra/assets/apache-cassandra-3.0.8-bin-dcos.tar.gzyet, which is used by default in the stub universe package. We intend to do that when we'll release our next version.